fix(nodebuilder): fix nil pointer exception and simplify synchronization #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2466 +/- ##
==========================================
+ Coverage 53.05% 53.12% +0.06%
==========================================
Files 156 156
Lines 9940 9935 -5
==========================================
+ Hits 5274 5278 +4
+ Misses 4210 4202 -8
+ Partials 456 455 -1
|
Wondertan
changed the title
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
commented
Jul 12, 2023
vgonkivs
previously approved these changes
Jul 13, 2023
renaynay
previously approved these changes
Jul 13, 2023
Wondertan
force-pushed
the
hlib/store/lock-fix
branch
from
acf7208
to
0bbe544
Compare
renaynay
approved these changes
Jul 13, 2023
vgonkivs
approved these changes
Jul 13, 2023
walldiss
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit an infamous use case here where nil is not nil. Also, I simplified locking here while thinking that's a race condition.